[awesome bugs] #957 - maximizing always honour size hints

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened. Details are below.

User who did this - alorewotik (alorewotik)

Attached to Project - awesome
Summary - maximizing always honour size hints
Task Type - Bug Report
Category - Core
Status - Unconfirmed
Assigned To -
Operating System - All
Severity - Low
Priority - Normal
Reported Version - git/master
Due in Version - Undecided
Due Date - Undecided
Details - Regardless of size_hints_honor state (true or false), changing of maximized_{horizontal,vertical} variable does honour size hints while resizing behaves correctly.

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - maximizing always honour size hints
User who did this - Uli Schlachter (psychon)

----------
Could you run xprop, click on the client and attach the output? Does this happen with everything or just with special apps? How do you change maximized_{horizontal,vertical}? Could you also run 'xwininfo | grep geometry' before and after settings maximized_{h,v} so that we know some exact numbers (Again, click on the client in question).

However, I'm not sure I understand your sentence correctly. Is this what you are saying:

size_hints_honor = true
- Resizing honors size hints
- maximized_{h,v} honors size hints

size_hints_honor = false
- Resizing does NOT honor size hints
- maximized_{h,v} honors size hints BUT IT SHOULD NOT

Oh and one more thing: Which awesome version (as printed by 'awesome -v')?
----------

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957#comment2845

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - maximizing always honour size hints
User who did this - alorewotik (alorewotik)

----------

Post by awesome
Could you run xprop

OK, xprop output is attached. Results before and after "size_hints_honor = false" are identical.

Post by awesome
Does this happen with everything or just with special apps?

It happens with all terminal emulators and GVim, e.g. all applications I use which have {width,height}_inc size hints.

Post by awesome
Could you also run 'xwininfo | grep geometry'

Before: -geometry 81x25+0+24
After: -geometry 159x60+0+24

Post by awesome
Is this what you are saying

Yes.

Post by awesome
Which awesome version

awesome v3.4-617-gc6e9208 (Closing In)

P.S. Additional information: after resizing window so it's "bigger" that maximized one, maximizing does work properly (fills all non-wibox screen space).
----------

One or more files have been attached.

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957#comment2846

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - maximizing always honour size hints
User who did this - Uli Schlachter (psychon)

----------

Post by awesome
OK, xprop output is attached. Results before and after "size_hints_honor = false" are identical.

Are you sure? This line should be different: _NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_VERT, _NET_WM_STATE_MAXIMIZED_HORZ

Post by awesome
Before: -geometry 81x25+0+24
After: -geometry 159x60+0+24

Uhm, is this in pixels? How large is your screen?

Also, are you really sure that this is an issue with size hints? Does the size match the size hints? Uhm...
----------

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957#comment2847

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - maximizing always honour size hints
User who did this - Lukas Hrazky (lukash)

----------
This happens to me too.

By default, windows honor size hints in tiled layout and when maximized.
With size_hints_honor = false, windows don't honor size hints in tiled layout, but still honor them when maximized (regardless of layout).

Version 3.5_rc1 and otherwise up-to-date funtoo current system. The windows in question are lxterminal. I don't have time to do xprop investigation, but this should be easily reproducible.
----------

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957#comment3280

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - maximizing always honour size hints
User who did this - Felix Bier (Wey)

----------
I used gdb with a breakpoint on client_resize_do in client.c. My monitor is 1600x900 and border_width=8. From what I can grasp, this happens:

When spawning a a terminal on a normal tiling layout, client_resize_do is initally called with {x = 0, y = 28, width = 1584, height = 856}, which is just as expected. Than another call happens with {x = 0, y = 28, width = 1582, height = 838}. I guess this is the size hinting. Finally it is called again with {x = 0, y = 28, width = 1584, height = 856}, this is induced by a signal handle of property::geometry.

Contrary, when setting a terminal to fullscreen, the last call does not happen. This is because the property::geometry callback layout.arrange in lib/awful/layout/init.lua does only invoke the screens layout.arrange on all tiled clients, and leaves out "floating" clients, which also includes maximized and fullscreened clients. Attached is an initial stab at that issue, though not very elegant.
----------

One or more files have been attached.

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957#comment3307

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

[awesome]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - maximizing always honour size hints
User who did this - Luigi Rocca (ggrocca)

----------
I confirm this bug in awesome v3.5.5 (Kansas City Shuffle), on Arch Linux.

The gaps happen not only when maximixing, but also when going fullscreen, despite setting honor_size_hints = false. The offending applicaion on my machine is Emacs. To clarify, this happens when maximizing/fullscreening single windows, not when the whole screen layout gets changed to max or max.fullscreen.

I manually applied Felix's patch to /usr/share/awesome/lib/awful .lua files and it works wonders - the issue is completely fixed. Could it be included in the main release with a bit of polish?

I personally don't see any reason for honoring the size hints in fullscreen/maximize mode even when honor_size_hints = false, but if this is the case maybe an additional option to control this behavior to could be added.

----------

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=957#comment4140

You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.